New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated warnings #313

Merged

simonoff merged 3 commits into rubyzip:master from koic:fix_deprecated_warnings

Feb 4, 2017

Contributor

koic commented Jan 8, 2017

Fix following deprecated warnings in rake test.

Use assert_nil if expecting nil
::[] is deprecated. Use ::new instead.
constant ::Fixnum is deprecated in Ruby 2.4 https://bugs.ruby-lang.org/issues/12005

Thanks.

koic added 2 commits

January 8, 2017 15:31


          Fix warnings: Use assert_nil if expecting nil

33d0949


          Fix warning: ::[] is deprecated. Use ::new instead.

7c250c0

coveralls commented Jan 8, 2017 •

edited

Coverage remained the same at 91.465% when pulling 83fb2f7 on koic:fix_deprecated_warnings into f34c1d9 on rubyzip:master.

3 similar comments

coveralls commented Jan 8, 2017

Coverage remained the same at 91.465% when pulling 83fb2f7 on koic:fix_deprecated_warnings into f34c1d9 on rubyzip:master.

coveralls commented Jan 8, 2017

Coverage remained the same at 91.465% when pulling 83fb2f7 on koic:fix_deprecated_warnings into f34c1d9 on rubyzip:master.

coveralls commented Jan 8, 2017

Coverage remained the same at 91.465% when pulling 83fb2f7 on koic:fix_deprecated_warnings into f34c1d9 on rubyzip:master.


          Fix warnings: constant ::Fixnum is deprecated in Ruby 2.4

960414a

koic force-pushed the fix_deprecated_warnings branch from 83fb2f7 to 960414a Compare

January 8, 2017 07:41

coveralls commented Jan 8, 2017 •

edited

Coverage remained the same at 91.465% when pulling 960414a on koic:fix_deprecated_warnings into f34c1d9 on rubyzip:master.

4 similar comments

coveralls commented Jan 8, 2017

Coverage remained the same at 91.465% when pulling 960414a on koic:fix_deprecated_warnings into f34c1d9 on rubyzip:master.

coveralls commented Jan 8, 2017

Coverage remained the same at 91.465% when pulling 960414a on koic:fix_deprecated_warnings into f34c1d9 on rubyzip:master.

coveralls commented Jan 8, 2017

Coverage remained the same at 91.465% when pulling 960414a on koic:fix_deprecated_warnings into f34c1d9 on rubyzip:master.

coveralls commented Jan 8, 2017

Coverage remained the same at 91.465% when pulling 960414a on koic:fix_deprecated_warnings into f34c1d9 on rubyzip:master.

bcook-r7 mentioned this pull request

bump metasploit to ruby 2.4 rapid7/metasploit-framework#7819

Merged

3 tasks

simonoff merged commit 28c5dd5 into rubyzip:master

koic deleted the fix_deprecated_warnings branch

February 4, 2017 22:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment